Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

chore(ci): update protractor to 1.0.0-rc5 and increase global timeout fo... - #8231

Closed
juliemr wants to merge 1 commit into
angular:masterfrom
juliemr:master
Closed

juliemr wants to merge 1 commit into
angular:masterfrom
juliemr:master

Conversation

@juliemr

@juliemr juliemr commented Jul 17, 2014

Copy link
Copy Markdown
Contributor

...r loading pages

This should help with occasional safari page load timeouts. In a test of
4500 page loads, the current 10 second limit caused 3 errors while a 30 second limit
caused none.

… for loading pages

This should help with occasional safari page load timeouts. In a test of
4500 page loads, the current 10 second limit caused 3 errors while a 30 second limit
caused none.
@mary-poppins

Copy link
Copy Markdown

Thanks for the PR! Please check the items below to help us merge this faster. See the contributing docs for more information.

  • Uses the issue template (#8231)

If you need to make changes to your pull request, you can update the commit with git commit --amend.
Then, update the pull request with git push -f.

Thanks again for your help!

@IgorMinar

Copy link
Copy Markdown
Contributor

lgtm

@juliemr juliemr added cla: yes and removed cla: no labels Jul 17, 2014
juliemr added a commit that referenced this pull request Jul 17, 2014
… for loading pages

This should help with occasional safari page load timeouts. In a test of
4500 page loads, the current 10 second limit caused 3 errors while a 30 second limit
caused none.

Closes #8231
@juliemr juliemr closed this in 2474173 Jul 17, 2014
@IgorMinar

Copy link
Copy Markdown
Contributor

merged

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants