Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

ngMockE2E points to incorrect script locations in docs #8038

Closed

Description

@krimple

The ngMockE2E module is not available in the locations shown, it is embedded in the angular-mocks.js script. Either make the file available as a separate script (which has the advantage of letting you use ngMockE2E in a production setting without forcing you to use the mock $log) or update the docs to point to the angular-mocks.js location.

The URL in question on the site: https://docs.angularjs.org/api/ngMockE2E

I tried the "improve this doc" link but couldn't find any reference to the links in the current repo.

Activity

  1. Narretz commented on Jul 21, 2014

    @Narretz
    Contributor

    The installation block is automatically inserted by dgeni.ngdoc (module template. https://github.com/angular/dgeni-packages/blob/master/ngdoc/templates/api/module.template.html)
    @petebacondarwin Is there a way to overwrite this behavior?

  2. added this to the milestone on Jul 21, 2014
  3. krimple commented on Jul 21, 2014

    @krimple
    Author

    Wouldn't it be best to split the ngMockE2E out into its own javascript file and then let it work as normal?

  4. petebacondarwin commented on Jul 21, 2014

    @petebacondarwin
    Contributor

    This is related to and can be solved in the same way as #7284

  5. pkozlowski-opensource commented on Jul 21, 2014

    @pkozlowski-opensource
    Member

    Yeh, we should close this one as a duplicate of #7284. Sorry @petebacondarwin , kind of didn't have time to look more into this one :-/

  6. petebacondarwin commented on Jul 21, 2014

    @petebacondarwin
    Contributor

    @pkozlowski-opensource - I am on it.

    I am not sure it is an exact duplicate, since @krimple would really like ngMockE2E to be packaged separately. This could be worth it. I expect that ngMockE2E it could be deprecated since ngScenario is being replaced by Protractor.

  7. shahata commented on Jul 21, 2014

    @shahata
    Contributor

    @petebacondarwin why is ngMockE2E less relevant with protractor than it was with ngScenario?

  8. added 2 commits that reference this issue on Jul 21, 2014
    2ad1b4c
    25eb9b7
  9. petebacondarwin commented on Jul 21, 2014

    @petebacondarwin
    Contributor

    Oops. @shahata - yes you are right. One can still implement ngMockE2E:$httpBackend if you want even if you use Protractor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions