This repository was archived by the owner on Apr 12, 2024. It is now read-only.
Repository navigation
This repository was archived by the owner on Apr 12, 2024. It is now read-only.
html5 mode with mismatching base href causes "TypeError: Cannot read property 'replace' of undefined" error in location.js #13565
Description
Looking at the latest version of location.js (https://github.com/angular/angular.js/blob/4412fe238f37f79a2017ee7b20ba089c0acd73e9/src/ng/location.js)
If the tag does not match the actual href, $$parseLinkUrl will miss all the conditions and rewrittenUrl will not be defined, which means this.$$parse will not be called and $$absUrl will not be set.
Later on line 902 (
Line 902 in 4412fe2
TypeError: Cannot read property 'replace' of undefined
Reacted by Lincoln W Daniel and Abhishek Rawat
Activity
Narretz commentedon Dec 17, 2015
I'm not sure I understand the problem. In what case would the base tag not match the actual href?
jamlee1 commentedon Jan 4, 2016
In my case, the html was being served on multiple domains. Granted, we can correct that base url, but it still shouldn't cause a javascript error in angular.
OverZealous commentedon Feb 23, 2016
I agree, this shouldn't cause an unknown error. This is happening to us, and we couldn't see it until production, and it simply killed the page. Having such a low-level JS error seems like something that should have feedback.
(It was a weird case in our situation, too, a production-only url rewrite that triggered an error.)
gkalpak commentedon Jun 3, 2016
Should be fixed by #14488.
fix($location) : initialize `$$absUrl` to empty string
fix($location) : initialize `$$absUrl` to empty string