This repository was archived by the owner on Dec 4, 2017. It is now read-only.
chore(docs): revise makeExcerpt mixin for DRYer ref to examples#1420
Merged
kwalrath merged 1 commit intoangular:masterfrom May 18, 2016
Merged
chore(docs): revise makeExcerpt mixin for DRYer ref to examples#1420kwalrath merged 1 commit intoangular:masterfrom
kwalrath merged 1 commit intoangular:masterfrom
Conversation
chalin
changed the title
Contributor
Author
Contributor
|
LGTM. @wardbell do you have an opinion? I wonder if the name makeExample1 could be clearer. makeExample2? makeSimpleExample? |
Member
|
Or perhaps |
Contributor
|
I like but the name has to change. Happy to accept after that change. |
Contributor
Author
|
I agree about the name, but figured I run by the basic idea first. I originally thought of: |
Be more DRY when referencing examples and excerpts. E.g.,
```jade
+makeExcerpt('quickstart/ts/app/app.component.ts', 'import',
'app/app.component.ts (import)')
```
can now be just
```jade
+makeExcerpt('app/app.component.ts', 'import')
```
Defined new mixin for examples named `makeExample1` using this new
scheme.
The original `makeExample` has been left untouched.
Applied new mixins to quickstart.
chalin
force-pushed
the
chalin-doc-quickstart-0517
branch
from
6be9c40 to
9abec7c
Compare
Contributor
Author
chalin
changed the title
Contributor
|
OK, I'll merge a little later this morning. Thanks, Patrice! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoiding
tsin the file path will make it a bit easier to construct the path to the Dart version (by simply appending to the path rather than having to massage the path).This update allows us to be more DRY when referencing examples and excerpts. E.g.,
can now be just
With the resulting examples and their titles being rendered the same as before. The original
makeExamplehas been left untouched.Applied new mixins to quickstart.