Thanks for the PR @filipesilva. I added a few comments, can you check?

Let me know what you'd like to do about webdriver and I'll add that in.

In the meanwhile, do you have something else specific for me to do? Or should I just go over help-wanted issues?

@filipesilva you can take any issue that you feel like taking. The focus now is to build a cross-platform e2e testing suite for the project, but any help would be appreciated.

I moved the webdriver-manager update command to the readme. Anything else you think should be changed?

@filipesilva let's just figure out how we'll integrate this with ng test so we can get this merged.

Hm... although ng test should be the umbrella command, unit tests and e2e have different use cases.

One would either run the unit tests once just to check everything is fine, or leave them running continuously while coding. In contrast, e2e tests are (in my experience) only ran once to check everything is fine.

Thus it might make sense to run e2e tests while running unit tests in single run, but it does not make sense to run e2e when unit tests are not in single run.

So to start off, I'd suggest that e2e tests are only ran explicitly, via ng test --e2e or something similar.

@filipesilva right on - see my comment: #86 (comment)

I'm not crazy about the manual steps we require, but we can fix that in follow up PRs.

How about renaming e2e extension to e2eSpec? Or is e2e clear enough? Maybe it is..

@juliemr do you have anything else you'd like to see in CLI when scaffolding the project/components?

I'm partial to just e2e. I feel it's clear enough and doesn't lead users towards camelCase for their file names, eg my-component.e2e.ts vs my-component.e2eSpec.ts, and variations my_component, myComponent.

@filipesilva can you rebase the PR so we can get this merged?

Apologies @cironunes, I had to return to docs for the last week.

This isn't ready to be merged yet though. While looking at the matchers that Igor was recommending, I found out since the *.e2e.ts files were being compiled to SystemJS module loading, that was causing all sorts of trouble when trying to use modules in general for protractor.

I will need to separate the e2e tests onto another folder, and provide it with tsconfig.json that uses CommonJS module loading.

I've updated the commit to reflect the major changes, so please review again.

Highlights:

• added e2e folder besides src with own tsconfig.json
• fixed imports
• added page object

@filipesilva can you rebase this with the latest changes from master?

Rebased and confirmed it was still working.

lgtm

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}