Skip to content

fix(@schematics/angular): add a TODO for negated arrayWithExactContents in refactor-jasmine-vitest #34691

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MeAkib wants to merge 1 commit into
base: main
Choose a base branch
from
+27 −1
Open

fix(@schematics/angular): add a TODO for negated arrayWithExactContents in refactor-jasmine-vitest #34691

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion packages/schematics/angular/refactor/jasmine-vitest/transformers/jasmine-matcher.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -413,6 +413,17 @@ export function transformArrayWithExactContents(
return node;
}

const expectCall = node.expression.expression.expression;

// Splitting a negated assertion would assert that neither condition holds instead of not both.
if (ts.isPropertyAccessExpression(expectCall) && expectCall.name.text === 'not') {
const category = 'arrayWithExactContents-negated';
reporter.recordTodo(category, sourceFile, node);
addTodoComment(node, category);

return node;
}

if (!ts.isArrayLiteralExpression(argument.arguments[0])) {
const category = 'arrayWithExactContents-dynamic-variable';
reporter.recordTodo(category, sourceFile, node);
Expand All @@ -427,7 +438,6 @@ export function transformArrayWithExactContents(
'Transformed `jasmine.arrayWithExactContents()` to `.toHaveLength()` and `.toEqual(expect.arrayContaining())`.',
);

const expectCall = node.expression.expression.expression;
const arrayLiteral = argument.arguments[0];

const lengthCall = ts.factory.createCallExpression(
Expand Down
10 changes: 10 additions & 0 deletions packages/schematics/angular/refactor/jasmine-vitest/transformers/jasmine-matcher_spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -256,6 +256,16 @@ describe('transformArrayWithExactContents', () => {
expect(myArray).toEqual(jasmine.arrayWithExactContents(someOtherArray));
`,
},
{
description: 'should add a TODO for a negated toEqual(jasmine.arrayWithExactContents())',
input: `expect(myArray).not.toEqual(jasmine.arrayWithExactContents(['a', 'b']));`,
/* eslint-disable max-len */
expected: `
// TODO: vitest-migration: Cannot transform a negated jasmine.arrayWithExactContents. Splitting it would assert that neither condition holds instead of not both. Please migrate this manually.
expect(myArray).not.toEqual(jasmine.arrayWithExactContents(['a', 'b']));
`,
/* eslint-enable max-len */
},
];

testCases.forEach(({ description, input, expected }) => {
Expand Down
6 changes: 6 additions & 0 deletions packages/schematics/angular/refactor/jasmine-vitest/utils/todo-notes.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,12 @@ export const TODO_NOTES = {
message:
'Cannot transform jasmine.arrayWithExactContents with a dynamic variable. Please migrate this manually.',
},
'arrayWithExactContents-negated': {
message:
'Cannot transform a negated jasmine.arrayWithExactContents. ' +
'Splitting it would assert that neither condition holds instead of not both. ' +
'Please migrate this manually.',
},
'arrayWithExactContents-check': {
message:
"Verify this matches strict array content (multiset equality). Vitest's arrayContaining is a subset check.",
Expand Down
Loading