Repository navigation
fix(@schematics/angular): add a TODO for negated arrayWithExactContents in refactor-jasmine-vitest - #34691
Open
MeAkib wants to merge 1 commit into
Open
fix(@schematics/angular): add a TODO for negated arrayWithExactContents in refactor-jasmine-vitest#34691MeAkib wants to merge 1 commit into
MeAkib wants to merge 1 commit into
Conversation
…ts in refactor-jasmine-vitest `transformArrayWithExactContents` splits the assertion into a `.toHaveLength()` check and a `.toEqual(expect.arrayContaining())` check without looking for `.not`. A negated assertion is split into two negated checks, which asserts that neither condition holds instead of not both: an array with the right length but different contents passes in Jasmine and fails after the migration. Vitest has no single matcher for exact-contents-in-any-order, so a faithful negation cannot be expressed by splitting. Leave the negated form unchanged and add a TODO comment instead, matching the existing handling of a dynamic (non-literal) argument. The new spec runs the full transform pipeline on a negated assertion; it fails without this change and `//packages/schematics/angular:test` passes with it.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds handling for negated jasmine.arrayWithExactContents assertions during the Jasmine-to-Vitest migration. It prevents incorrect splitting of negated assertions by adding a TODO comment for manual migration instead. A test case and the corresponding TODO message definition have also been added. I have no feedback to provide as the implementation is clean and correct.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
transformArrayWithExactContentssplits the assertion into a.toHaveLength()check and a.toEqual(expect.arrayContaining())check without looking for.not. A negated assertion is split into two negated checks, which asserts that neither condition holds instead of not both: an array with the right length but different contents passes in Jasmine and fails after the migration.Vitest has no single matcher for exact-contents-in-any-order, so a faithful negation cannot be expressed by splitting. Leave the negated form unchanged and add a TODO comment instead, matching the existing handling of a dynamic (non-literal) argument.