Repository navigation
fix(@angular/cli): fix pnpm-workspace.yaml sanitization when using pnpm patches - #34681
Merged
alan-agius4 merged 1 commit intoNov 11, 2026
Merged
Conversation
…pnpm patches This change removes pnpm patches from the sanitized `pnpm-workspace.yaml`.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the sanitizePnpmWorkspace function to correctly identify and remove patchedDependencies blocks during temporary installations, ensuring that relative patch paths do not interfere with the temporary environment. Documentation has been updated to reflect this change, and a corresponding test case has been added to verify the behavior. I have no further feedback to provide.
alan-agius4
approved these changes
Nov 11, 2026
alan-agius4
added
target: patch
3 of 13 tasks
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change removes pnpm patches from the sanitized
pnpm-workspace.yaml.PR Checklist
Please check to confirm your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Running
ng updatein a pnpm workspace with patches creates a temporary install and then pnpm complains it can't find the patches defined in thepnpm-workspace.yamlfor a path that a developer is unaware of (and it gets cleaned up so it can't be inspected).What is the new behavior?
Running
ng updatewith pnpm patches works normally.Does this PR introduce a breaking change?
Other information