fix(@angular/cli): update MCP devserver tool names to conform to spec regex#33629
Open
clydin wants to merge 1 commit into
Open
fix(@angular/cli): update MCP devserver tool names to conform to spec regex#33629clydin wants to merge 1 commit into
clydin wants to merge 1 commit into
Conversation
… regex MCP tool names must adhere to the regular expression ^[a-zA-Z0-9_-]+$. This commit updates devserver.start, devserver.stop, and devserver.wait_for_build to use underscores (devserver_start, devserver_stop, devserver_wait_for_build) and updates all corresponding tool references and documentation across the MCP command package.
2 tasks
clydin
added
the
action: review
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request replaces dots with underscores in MCP tool names (e.g., renaming devserver.start to devserver_start) and updates all corresponding references in descriptions and error messages. A review comment suggests fixing a minor grammatical repetition ("that that app") in the description of the devserver_start tool.
| * **Keeping the Server Alive**: It is often better to keep the server alive between tool calls if you expect the user to request more | ||
| changes or run more tests, as it saves time on restarts and maintains the file watcher state. You must still call | ||
| 'devserver.wait_for_build' after every change to see whether the change was successfully built and be sure that that app was updated. | ||
| 'devserver_wait_for_build' after every change to see whether the change was successfully built and be sure that that app was updated. |
There was a problem hiding this comment.
The phrase "that that app" is repetitive and can be simplified to "the app" to improve readability.
Suggested change
| 'devserver_wait_for_build' after every change to see whether the change was successfully built and be sure that that app was updated. | |
| 'devserver_wait_for_build' after every change to see whether the change was successfully built and be sure that the app was updated. |
alan-agius4
approved these changes
Jul 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MCP tool names must adhere to the regular expression ^[a-zA-Z0-9_-]+$. This commit updates devserver.start, devserver.stop, and devserver.wait_for_build to use underscores (devserver_start, devserver_stop, devserver_wait_for_build) and updates all corresponding tool references and documentation across the MCP command package.