refactor(@angular/ssr): drain node stream#29491
Merged
alan-agius4 merged 1 commit intoangular:mainfrom Jan 28, 2025
Merged
Conversation
alan-agius4
requested changes
Jan 27, 2025
Collaborator
There was a problem hiding this comment.
Thanks for your contribution.
- Please squash the commits.
- In the commit message body, can you please context of the change. This is important for future users that are checking the diff to see what certain code has been done etc..
- Use async/await where possible
alan-agius4
added
the
action: cleanup
alexfriesen
force-pushed
the
feat/node-stream-drain
branch
from
d558772 to
7d6d7f6
Compare
alexfriesen
force-pushed
the
feat/node-stream-drain
branch
from
7d6d7f6 to
7481f30
Compare
alan-agius4
approved these changes
Jan 27, 2025
Collaborator
alan-agius4
left a comment
alan-agius4
left a comment
There was a problem hiding this comment.
LGTM, thanks for your contribution.
alan-agius4
added
action: review
Collaborator
|
The changes were merged into the following branches: main, 19.1.x |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check to confirm your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
writeResponseToNodeResponse will stream an response without draining.
Issue Number: N/A
What is the new behavior?
Node.js streams should be drained to ensure efficient and uninterrupted data flow. This PR adds draining logic to
writeResponseToNodeResponseDoes this PR introduce a breaking change?
Other information
I'm not sure if all checks will pass. Bazel is a weird alien to me