Skip to content

refactor(@angular-devkit/build-angular): remove NG_BUILD_PROFILING and DEVKIT_PROFILING logic#22292

Merged
filipesilva merged 1 commit into
angular:masterfrom
alan-agius4:remove-profiling
Dec 6, 2021
Merged

refactor(@angular-devkit/build-angular): remove NG_BUILD_PROFILING and DEVKIT_PROFILING logic#22292
filipesilva merged 1 commit into
angular:masterfrom
alan-agius4:remove-profiling

Conversation

@alan-agius4

Copy link
Copy Markdown
Collaborator

Generating a CPU profile using Node.JS --cpu-prof or Chrome inspector is preferred.

Closes #20336

…and `DEVKIT_PROFILING` logic

Generating a CPU profile using Node.JS `--cpu-prof` or Chrome insector is preferred.

Closes #20336
@alan-agius4 alan-agius4 added the target: minor This PR is targeted for the next minor release label Dec 3, 2021
@alan-agius4 alan-agius4 requested a review from dgp1130 December 3, 2021 10:14
@google-cla google-cla Bot added the cla: yes label Dec 3, 2021

@dgp1130 dgp1130 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cleaning this up! Glad we can simplify our infra and support here.

Comment thread packages/angular_devkit/build_angular/src/webpack/configs/common.ts
@alan-agius4 alan-agius4 added the action: merge The PR is ready for merge by the caretaker label Dec 3, 2021
@filipesilva filipesilva merged commit 9e22d7a into angular:master Dec 6, 2021
@angular-automatic-lock-bot

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Jan 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker target: minor This PR is targeted for the next minor release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Document NG_BUILD_PROFILING

3 participants