docs: update testing chapter with general test commands#18714
Merged
alan-agius4 merged 1 commit intoangular:masterfrom Sep 8, 2020
Merged
docs: update testing chapter with general test commands#18714alan-agius4 merged 1 commit intoangular:masterfrom
alan-agius4 merged 1 commit intoangular:masterfrom
Conversation
alan-agius4
reviewed
Sep 7, 2020
alan-agius4
reviewed
Sep 7, 2020
Collaborator
alan-agius4
left a comment
alan-agius4
left a comment
There was a problem hiding this comment.
The change needs to be done in the readme template https://github.com/angular/angular-cli/blob/master/scripts/templates/readme.ejs
Afterwards you need to run yarn admin templates to generate the MD file.
Contributor
Author
|
Sorry, I didn't know this will apply these changes. |
Jefiozie
force-pushed
the
fix_testing_readme
branch
from
0adb7b7 to
4df6b95
Compare
alan-agius4
reviewed
Sep 7, 2020
alan-agius4
reviewed
Sep 7, 2020
alan-agius4
reviewed
Sep 7, 2020
alan-agius4
requested changes
Sep 7, 2020
Collaborator
alan-agius4
left a comment
alan-agius4
left a comment
There was a problem hiding this comment.
Thanks for this.
A couple of small comments above.
Jefiozie
force-pushed
the
fix_testing_readme
branch
from
4df6b95 to
5b5f7b0
Compare
Contributor
Author
|
I've made the requested changes let me know if I need to make more changes. |
alan-agius4
added
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated the information around testing as discussed in #18710
Closes: #18710