Skip to content

feat(@schematics/angular): update to TypeScript 3.6 - #15881

Merged
vikerman merged 3 commits into
masterfrom
alan-agius4-ts-3.6
Oct 21, 2019
Merged

vikerman merged 3 commits into
masterfrom
alan-agius4-ts-3.6

Conversation

@alan-agius4

Copy link
Copy Markdown
Collaborator

No description provided.

@alan-agius4 alan-agius4 added the target: major This PR is targeted for the next major release label Oct 19, 2019

@filipesilva filipesilva left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#15879 is needed for this to work.

Angular will only support TS 3.6+ on version 9, and older versions of `@types/node` are incompatible with it and will cause all builds to fail.

Related to angular/angular#33250
@googlebot

This comment has been minimized.

@alan-agius4

Copy link
Copy Markdown
Collaborator Author

@googlebot I consent

@filipesilva

Copy link
Copy Markdown
Contributor

@googlebot I consent.

@googlebot

Copy link
Copy Markdown

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@vikerman
vikerman merged commit 3c9305b into master Oct 21, 2019
@alan-agius4
alan-agius4 deleted the alan-agius4-ts-3.6 branch October 21, 2019 17:20
@angular-automatic-lock-bot

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Nov 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

target: major This PR is targeted for the next major release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants