Skip to content

Add deploy command doc - #15402

Merged
kyliau merged 5 commits into
angular:masterfrom
jbogarthyde:jb-deploy-doc
Aug 22, 2019
Merged

kyliau merged 5 commits into
angular:masterfrom
jbogarthyde:jb-deploy-doc

Conversation

@jbogarthyde

Copy link
Copy Markdown
Contributor

Adding some more detail to the API doc for the new ng deploy command.

@jbogarthyde jbogarthyde added effort1: easy (hours) P5 The team acknowledges the request but does not plan to address it, it remains open for discussion area: docs Related to the documentation freq1: low Only reported by a handful of users who observe it rarely severity1: confusing area: @angular/cli target: patch This PR is targeted for the next patch release labels Aug 21, 2019
@jbogarthyde
jbogarthyde requested a review from mgechev August 21, 2019 19:17
@jbogarthyde jbogarthyde self-assigned this Aug 21, 2019
When a project name is not supplied, executes the `deploy` builder for the default project.

When a project name is not supplied, the CLI will execute the `deploy` builder for the default project.
The deploy builder defined in a deployment platform package is automatically added to a project's configuration when you add the package to the project.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we update it to something like:

To use the ng deploy command ng add a package that implements deployment capabilities to your favorite platform. The ng-add schematics of the package will automatically update your workspace configuration, adding a deployment CLI builder.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also adding link to CLI Builder guide.

@mgechev mgechev left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left few comments. Thanks for remembering to update the deploy-long.md!

```
To use the `ng deploy` command, use `ng add` to add a package that implements deployment capabilities to your favorite platform.
Adding the package automatically updates your workspace configuration, adding a deployment
`CLI builder`(guide/cli-builder).

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Users see deploy-long.md when the run ng deploy --help as well and this won't be rendered properly. Maybe we can drop it?

Suggested change
`CLI builder`(guide/cli-builder).
`CLI builder`.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK -- but I think the long description only shows up in AIO, not in the help.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, feel free to ignore my comment.

@mgechev mgechev left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last small comment. Otherwise, LGTM.

@mgechev

mgechev commented Aug 21, 2019

Copy link
Copy Markdown
Member

@kyliau the failure is because the CLI's size increased with the doc change.

@kyliau
kyliau merged commit fe3d597 into angular:master Aug 22, 2019
kyliau pushed a commit that referenced this pull request Aug 22, 2019
* docs: add deploy command doc

* docs: fix json example

* docs: add link to cli builder doc

* docs: remove link

* docs: restore link
@angular-automatic-lock-bot

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area: @angular/cli area: docs Related to the documentation effort1: easy (hours) freq1: low Only reported by a handful of users who observe it rarely P5 The team acknowledges the request but does not plan to address it, it remains open for discussion severity1: confusing target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants