fix(@ngtools/webpack): log ngcc info messages by filipesilva · Pull Request #14320 · angular/angular-cli

filipesilva · 2019-05-01T10:33:28Z

This PR by itself will address #14194, but needs angular/angular#30232 in order to not be spammy.

filipesilva · 2019-05-01T10:34:53Z

Below is how the logging looks like with this PR.

First build:

$ ng serve
** Angular Live Development Server is listening on localhost:4200, open your browser on http://localhost:4200/ **
  0% compiling
Compiling @angular/core : es2015 as esm2015

Skipping @angular/core : module (already compiled).

Skipping @angular/core : es2015 (already compiled).

Skipping @angular/core : module (already compiled).

Compiling @angular/common : es2015 as esm2015

Skipping @angular/common : module (already compiled).

Compiling @angular/platform-browser : es2015 as esm2015

Skipping @angular/platform-browser : module (already compiled).

Compiling @angular/platform-browser-dynamic : es2015 as esm2015

Skipping @angular/platform-browser-dynamic : module (already compiled).

Date: 2019-05-01T10:31:54.903Z
Hash: 59fc7c2b9028bae08d65
Time: 28327ms
chunk {main} main.js, main.js.map (main) 9.81 kB [initial] [rendered]
chunk {polyfills} polyfills.js, polyfills.js.map (polyfills) 247 kB [initial] [rendered]
chunk {polyfills-es5} polyfills-es5.js, polyfills-es5.js.map (polyfills-es5) 380 kB [initial] [rendered]
chunk {runtime} runtime.js, runtime.js.map (runtime) 6.08 kB [entry] [rendered]
chunk {styles} styles.js, styles.js.map (styles) 16.3 kB [initial] [rendered]
chunk {vendor} vendor.js, vendor.js.map (vendor) 3.72 MB [initial] [rendered]
i ｢wdm｣: Compiled successfully.

Next builds:

$ ng serve
** Angular Live Development Server is listening on localhost:4200, open your browser on http://localhost:4200/ **

Date: 2019-05-01T10:32:15.250Z
Hash: 59fc7c2b9028bae08d65
Time: 10861ms
chunk {main} main.js, main.js.map (main) 9.81 kB [initial] [rendered]
chunk {polyfills} polyfills.js, polyfills.js.map (polyfills) 247 kB [initial] [rendered]
chunk {polyfills-es5} polyfills-es5.js, polyfills-es5.js.map (polyfills-es5) 380 kB [initial] [rendered]
chunk {runtime} runtime.js, runtime.js.map (runtime) 6.08 kB [entry] [rendered]
chunk {styles} styles.js, styles.js.map (styles) 16.3 kB [initial] [rendered]
chunk {vendor} vendor.js, vendor.js.map (vendor) 3.72 MB [initial] [rendered]
i ｢wdm｣: Compiled successfully.

filipesilva · 2019-05-01T10:35:57Z

 }

 class NgccLogger implements Logger {
+  private alreadyProcessMsg = 'The target entry-point has already been processed';


If ngcc change its logging messages our filter will break.

@petebacondarwin @gkalpak do you have a suggestion on a better way to log only when something is actually happening?

How about we just agree to change the info messages that you do not wish to see to debug messages? Then you don't need to filter at all?

But I think it would also be fair for CLI to output a message before ngcc is triggered to say something like "Compiling Angular packages with ngcc".

It's hard to go down that route because the CLI doesn't know if ngcc will try to compile a package or skip it. If we had such message it would come up on every build, several times.

alan-agius4 · 2019-05-01T11:36:41Z

+  info(..._args: string[]) {
+    const msg = _args.join(' ');
+    if (!msg.includes(this.alreadyProcessMsg)) {
+      process.stderr.write(`\n${msg}\n`);


Why not use the standard output?

Because it's a progress-like message. The webpack ProgressPlugin uses stderr for progress reporting, and so does Architect CLI.

I remember a discussion with @clydin about this too where I was pretty convinced progress-like messages should go there.

Thanks for the clarification

alan-agius4 · 2019-05-01T11:41:14Z

+  info(..._args: string[]) {
+    const msg = _args.join(' ');
+    if (!msg.includes(this.alreadyProcessMsg)) {
+      process.stderr.write(`\n${msg}\n`);


Maybe we should only print the compiling messages.

We should skip all others, such as skipping target already compiled and target entrypoint already compiled.

Something along:
If (msg.startsWith(‘Compiling’)) {

@petebacondarwin should ngcc also log Skipping messages as debug?

If you like 🤗

I'm good with that approach then. @alan-agius4 WDYT?

Please send a PR :-)

Sounds good to me

PR up at angular/angular#30232, PTAL @petebacondarwin. I'll then change this PR to log all info messages instead.

Fix angular#14194

#30232) Related to angular/angular-cli#14194, angular/angular-cli#14320 PR Close #30232

Fix #14194

angular#30232) Related to angular/angular-cli#14194, angular/angular-cli#14320 PR Close angular#30232

angular-automatic-lock-bot · 2019-09-13T02:40:56Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

filipesilva requested a review from alan-agius4 May 1, 2019 10:33

googlebot added the cla: yes label May 1, 2019

filipesilva commented May 1, 2019

View reviewed changes

filipesilva added the target: patch This PR is targeted for the next patch release label May 1, 2019

alan-agius4 reviewed May 1, 2019

View reviewed changes

filipesilva added the state: blocked label May 2, 2019

filipesilva mentioned this pull request May 2, 2019

fix(compiler-cli): log ngcc skipping messages as debug instead of info angular/angular#30232

Closed

3 of 14 tasks

fix(@ngtools/webpack): log ngcc info messages

cefcf84

Fix angular#14194

filipesilva changed the title ~~fix(@ngtools/webpack): log ngcc compilation messages~~ fix(@ngtools/webpack): log ngcc info messages May 2, 2019

filipesilva force-pushed the ngcc-info-log branch from ff7b995 to cefcf84 Compare May 2, 2019 13:23

filipesilva requested a review from alan-agius4 May 2, 2019 13:23

filipesilva removed the state: blocked label May 2, 2019

alan-agius4 approved these changes May 2, 2019

View reviewed changes

kara pushed a commit to angular/angular that referenced this pull request May 6, 2019

fix(compiler-cli): log ngcc skipping messages as debug instead of info (

60a8888

#30232) Related to angular/angular-cli#14194, angular/angular-cli#14320 PR Close #30232

kara pushed a commit to angular/angular that referenced this pull request May 6, 2019

fix(compiler-cli): log ngcc skipping messages as debug instead of info (

548b003

#30232) Related to angular/angular-cli#14194, angular/angular-cli#14320 PR Close #30232

alexeagle merged commit b9479b5 into angular:master May 7, 2019

alexeagle pushed a commit that referenced this pull request May 7, 2019

fix(@ngtools/webpack): log ngcc info messages (#14320)

a9262be

Fix #14194

BioPhoton pushed a commit to BioPhoton/angular that referenced this pull request May 21, 2019

fix(compiler-cli): log ngcc skipping messages as debug instead of info (

a602563

angular#30232) Related to angular/angular-cli#14194, angular/angular-cli#14320 PR Close angular#30232

angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 13, 2019

Conversation

filipesilva commented May 1, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

filipesilva commented May 1, 2019

Uh oh!

filipesilva May 1, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

alan-agius4 May 1, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

alan-agius4 May 1, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

angular-automatic-lock-bot Bot commented Sep 13, 2019

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

filipesilva commented May 1, 2019 •

edited

Loading

filipesilva May 1, 2019 •

edited

Loading

alan-agius4 May 1, 2019 •

edited

Loading

alan-agius4 May 1, 2019 •

edited

Loading