Repository navigation
fix(@ngtools/webpack): replace bootstrap code under Ivy unless running in JIT mode - #14180
Merged
Merged
Conversation
…g in JIT mode The bootstrap code always needs to be replaced if not running in JIT mode as other wise the entire compiler will be pulled in because we will not replace the bootstrapping code to use `platform-browser` instead of `platform-browser-dynamic`.
alan-agius4
commented
Apr 16, 2019
| : /bootstrapModuleFactory\([a-z]+\)\./; | ||
|
|
||
| const mainES2015 = readdirSync('./dist/test-project').find(name => !!name.match(/main-es2015.[a-z0-9]+\.js/)); | ||
| expectFileToMatch(`dist/test-project/${mainES5}`, /bootstrapModuleFactory\(/); |
Collaborator
Author
There was a problem hiding this comment.
This regexp was actually matching the entire contents of the bundle, and in fact this test was not failing for Ivy
alan-agius4
changed the title
alan-agius4
added
the
target: major
filipesilva
suggested changes
Apr 16, 2019
added 2 commits
April 16, 2019 10:48
… to be present in the bundle
filipesilva
approved these changes
Apr 16, 2019
alexeagle
approved these changes
Apr 16, 2019
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(@ngtools/webpack): replace bootstrap code under Ivy unless running in JIT mode
The bootstrap code always needs to be replaced if not running in JIT mode as other wise the entire compiler will be pulled in because we will not replace the bootstrapping code to use
platform-browserinstead ofplatform-browser-dynamic.