fix(@angular-devkit/build-angular): ensure correct dev server path with public host option - #13838
Merged
Merged
Conversation
clydin
force-pushed
the
server-custom-path
branch
from
March 7, 2019 00:12
179bfb2 to
a12c0c7
Compare
alan-agius4
reviewed
Mar 14, 2019
clydin
added
target: rc
clydin
added
target: patch
alan-agius4
approved these changes
Mar 29, 2019
…th public host option If a custom path is provided the webpack dev server client drops the sockjs-node segment. This adds it back so that behavior is consistent when using a custom URL path. Fixes angular#13627
clydin
force-pushed
the
server-custom-path
branch
from
March 29, 2019 22:03
a12c0c7 to
3f1ee2c
Compare
clydin
added
target: major
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a custom path is provided the webpack dev server client drops the sockjs-node segment. This adds it back so that behavior is consistent when using a custom URL path.
Fixes #13627