Skip to content

fix(@schematics/angular): use enableIvy as true - #13626

Merged
mgechev merged 1 commit into
angular:masterfrom
filipesilva:enableivy-true
Feb 22, 2019
Merged

mgechev merged 1 commit into
angular:masterfrom
filipesilva:enableivy-true

Conversation

@filipesilva

Copy link
Copy Markdown
Contributor

@filipesilva
filipesilva requested a review from clydin February 20, 2019 12:49
@filipesilva filipesilva added the target: major This PR is targeted for the next major release label Feb 20, 2019

@clydin clydin left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Couple CI failures though. Not sure if they are related.

@filipesilva

Copy link
Copy Markdown
Contributor Author

The test-large isn't but the e2e is. I think this PR needs to wait for the next release of angular to use that in the e2e test.

@mgechev
mgechev merged commit becd2f5 into angular:master Feb 22, 2019
@angular-automatic-lock-bot

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

target: major This PR is targeted for the next major release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants