Skip to content

Edit and expand command docs - #12741

Closed
jbogarthyde wants to merge 6 commits into
angular:masterfrom
jbogarthyde:jb-doc-edit
Closed

Edit and expand command docs#12741
jbogarthyde wants to merge 6 commits into
angular:masterfrom
jbogarthyde:jb-doc-edit

Conversation

@jbogarthyde

@jbogarthyde jbogarthyde commented Oct 24, 2018

Copy link
Copy Markdown
Contributor

This one is just the top-level commands. Will do separate PR for subcommands (generation schematics).

@jbogarthyde jbogarthyde added effort1: easy (hours) area: docs Related to the documentation area: @angular/cli target: patch This PR is targeted for the next patch release labels Oct 24, 2018
alan-agius4
alan-agius4 reviewed Oct 25, 2018
View reviewed changes
Comment thread packages/angular/cli/commands/run.json Outdated
alan-agius4
alan-agius4 reviewed Oct 25, 2018
View reviewed changes
Comment thread packages/angular/cli/commands/run.json Outdated
hansl
hansl reviewed Oct 25, 2018
View reviewed changes
Comment thread packages/angular/cli/commands/definitions.json Outdated
hansl
hansl suggested changes Oct 25, 2018
View reviewed changes

@hansl hansl left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good. 3 comments by Alan and I.

Comment thread packages/angular/cli/commands/run.json Outdated
@jbogarthyde

jbogarthyde commented Oct 25, 2018 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Please provide an example using the run command with the universal target. I would like to add it to the long description:
"Additional predefined Architect targets are available that do not correspond to CLI commands. For example, ..."

@alan-agius4

alan-agius4 commented Oct 27, 2018

Copy link
Copy Markdown
Collaborator

@jbogarthyde that would be

ng run <project>:server

// prod
ng run <project>:server:production

@jbogarthyde

jbogarthyde commented Oct 30, 2018

Copy link
Copy Markdown
Contributor Author

@hansl I have addressed your requested changes - please check and remove blocker.
@alan-agius4
Do either of you know why it's failing continuous-integration?

alan-agius4
alan-agius4 reviewed Oct 30, 2018
View reviewed changes
Comment thread packages/angular/cli/commands/definitions.json Outdated
@alan-agius4 alan-agius4 mentioned this pull request Oct 30, 2018
Closed
alan-agius4
alan-agius4 reviewed Oct 30, 2018
View reviewed changes
Comment thread packages/angular/cli/commands/run-long.md Outdated
alan-agius4
alan-agius4 approved these changes Oct 30, 2018
View reviewed changes

@alan-agius4 alan-agius4 left a comment •
edited
Loading

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much, Left one small comment.

@jbogarthyde jbogarthyde mentioned this pull request Nov 1, 2018
Closed
@jbogarthyde

jbogarthyde commented Nov 1, 2018

Copy link
Copy Markdown
Contributor Author

Moved these commits to docs-preview branch - PR Docs preview #12837

@jbogarthyde jbogarthyde closed this Nov 1, 2018
@jbogarthyde
jbogarthyde deleted the jb-doc-edit branch November 1, 2018 18:01
@angular-automatic-lock-bot

angular-automatic-lock-bot Bot commented Sep 12, 2019

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@alan-agius4 alan-agius4 alan-agius4 approved these changes
+1 more reviewer
@hansl hansl hansl requested changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area: @angular/cli area: docs Related to the documentation effort1: easy (hours) target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jbogarthyde @alan-agius4 @hansl @googlebot