Repository navigation
fix(@ngtools/webpack): barrel files fail on windows - #12567
Merged
Merged
Conversation
alan-agius4
commented
Oct 12, 2018
| if (fs.statSync(module).isDirectory()) { | ||
| const indexModule = join(module, 'index.ts'); | ||
| if (fs.existsSync(indexModule)) { | ||
| // If it's a file it will return false |
Collaborator
Author
There was a problem hiding this comment.
Paths here are not FS, they are normalized for virtual host
alan-agius4
added
the
target: patch
filipesilva
approved these changes
Oct 12, 2018
filipesilva
left a comment
filipesilva
left a comment
Contributor
There was a problem hiding this comment.
Great catch, and glad we have a test for it now 👍
alan-agius4
added
target: patch
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #12035
Fixes #12589
Fixes #8581