Angular RC5 app updated from CLI beta 10 to webpack 2 giving issues. #1665

Activity

1. vapits commented on Aug 12, 2016

   

   vapits

   on Aug 12, 2016

   More actions

   Remove module.id from all components.
   This will solve your issues.

   👍React with 👍2Reacted by Adam Zander and Rocky
2. hassanasad commented on Aug 12, 2016

   

   hassanasad

   on Aug 12, 2016

   Last edited by hassanasad

   Author

   More actions

   Wow thanks @vapits - It really did clear out those errors. I believe this should be mentioned on the update guide as well.

   I now hit another issue if you be kind enough to shine some light on it :)

   Error: Uncaught (in promise): TypeError: Cannot read property 'import' of undefined
   

   Also i noticed that if i change the most of the files CLI re-bundles the app but for some reason the it doesn't notice any changes for one of the modules which is really weird. Any ideas what might be wrong?
3. vapits commented on Aug 12, 2016

   

   vapits

   on Aug 12, 2016

   Last edited by vapits

   More actions

   Well without your code in this can't be sure.
   Open a SO question is my proposal with your code and close this issue.
4. antonyRoberts commented on Aug 12, 2016

   

   antonyRoberts

   on Aug 12, 2016

   Last edited by antonyRoberts

   More actions

   hassan the solution for your problem is not to delete moduleId from everything, that will lead to errors importing if you don't change all of your paths.

   The answer to the issue is this pull request.

   angular/angular@f54f9ef

   For you to apply it yourself all you need to do is change metadata_resolver.js in your build

   You'll have to go back and undo all of your module.id deletes, or update paths on all of the files you removed moudleId from
5. vapits commented on Aug 12, 2016

   

   vapits

   on Aug 12, 2016

   More actions

   @antonyRoberts
   module.id from components should be removed. Directives also.
6. hassanasad commented on Aug 13, 2016

   

   hassanasad

   on Aug 13, 2016

   Author

   More actions

   So basically i found out that the routes which contain loadChildren property do not detect saved changes for that module.

   For example:

   const routes: Routes = [
       { path: 'catalog', loadChildren: './catalog/catalog.module' },
       { path: 'login', loadChildren: './login/login.module' },
       { path: 'profile', component: ProfileComponent},
       { path: '', redirectTo: '/catalog', terminal: true },
       { path: '**', component: PageNotFoundComponent },   
   ];
   
   export const routing = RouterModule.forRoot(routes);
   

   In the above code - /login and /catalog modules do not push saved changes for webpack to rebundle. Perhaps its intentional? (because thats a separate NgModule)
7. hassanasad commented on Aug 15, 2016

   

   hassanasad

   on Aug 15, 2016

   Author

   More actions

   Update: This is actually an issue with webpack version of Angular. Here is a solution that should work while angular-cli is being updated: https://gist.github.com/brandonroberts/02cc07face25886fe142c4dbd8da1340
8. filipesilva commented on Aug 22, 2016

   

   filipesilva

   on Aug 22, 2016

   Contributor

   More actions

   module.id removal is mentioned on the upgrade procedure: https://github.com/angular/angular-cli/blob/master/WEBPACK_UPDATE.md

   ./src/app/app.component.ts (and all other components) - removed module.id, sass/less/stylus preprocessing now uses the real extension in styleUrls instead of .css.

   The loadChildren issues are addressed by #1632
9. filipesilva

   closed this as completedon Aug 22, 2016
10. angular-automatic-lock-bot commented on Sep 6, 2019

    

    angular-automatic-lock-botBot

    on Sep 6, 2019

    More actions

    This issue has been automatically locked due to inactivity.
    Please file a new issue if you are encountering a similar or related problem.

    Read more about our automatic conversation locking policy.

    _{This action has been performed automatically by a bot.}
11. angular-automatic-lock-bot

    locked and limited conversation to collaborators on Sep 6, 2019