Skip to content

8 migration does not remove commented polyfills #14234

Closed

Description

@filipesilva

CLI 7 projects have almost all polyfills commented out except zone.js.

The CLI 8 migration attempts to remove polyfills imports by parsing the AST, but since they are commented out they never show up.

The migration should remove these imports regardless of being commented out, since they aren't necessary anymore.

Activity

  1. added this to the needsTriage milestone on Apr 22, 2019
  2. modified the milestones: needsTriage, Backlog on Apr 22, 2019
  3. modified the milestones: Backlog, 8.0 on Apr 22, 2019
  4. self-assigned this
    on May 14, 2019
  5. filipesilva commented on May 16, 2019

    @filipesilva
    ContributorAuthor

    This should be ok now. We also check for known hashes of unmodified polyfills file, for both Linux and Windows, and replace those. That should cover most of the comment cases.

  6. angular-automatic-lock-bot commented on Sep 9, 2019

    @angular-automatic-lock-bot

    This issue has been automatically locked due to inactivity.
    Please file a new issue if you are encountering a similar or related problem.

    Read more about our automatic conversation locking policy.

    This action has been performed automatically by a bot.

  7. locked and limited conversation to collaborators on Sep 9, 2019
  8. removed their assignment
    on Jun 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions