Skip to content

Add experimentalImportFactories when migrating to loadChildren import syntax #14218

Closed

Description

@filipesilva

The #14181 migration also needs to add "experimentalImportFactories": true to angular.json (#13948) to make the import syntax supported in VE.

The tsconfig file should also be updated to use "module": "esnext", and a e2e test should be added to test the update works and an app with lazy routes will be updated and runs properly.

Activity

  1. added this to the 8.0 milestone on Apr 19, 2019
  2. modified the milestone: 8.0 on Apr 19, 2019
  3. added this to the 8.0 milestone on Apr 19, 2019
  4. modified the milestones: 8.0, Backlog on Apr 19, 2019
  5. modified the milestones: Backlog, 8.0 on Apr 19, 2019
  6. filipesilva commented on Apr 19, 2019

    @filipesilva
    ContributorAuthor

    Part of this is done in #14222

  7. alexeagle commented on Apr 22, 2019

    @alexeagle
    Contributor

    We should add this in the same migration with fix-lazy-routes so if we drop that feature from RC, we also drop the addition of this "experimental" flag

  8. added a commit that references this issue on Apr 22, 2019
    3464b75
  9. alexeagle commented on Apr 22, 2019

    @alexeagle
    Contributor

    Don't need this one if we do #14231

  10. added a commit that references this issue on Apr 22, 2019
    0f9de92
  11. angular-automatic-lock-bot commented on Sep 9, 2019

    @angular-automatic-lock-bot

    This issue has been automatically locked due to inactivity.
    Please file a new issue if you are encountering a similar or related problem.

    Read more about our automatic conversation locking policy.

    This action has been performed automatically by a bot.

  12. locked and limited conversation to collaborators on Sep 9, 2019
  13. added a commit that references this issue on May 29, 2026
    e41100b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions