Skip to content

[ivy] ng new ivy4ever --experimentalIvy=true doesn't add aot: true option #13646

Closed

Description

@wKoza

🚀 Feature request

Command (mark with an x)

- [X] new
- [ ] build
- [ ] serve
- [ ] test
- [ ] e2e
- [ ] generate
- [ ] add
- [ ] update
- [ ] lint
- [ ] xi18n
- [ ] run
- [ ] config
- [ ] help
- [ ] version
- [ ] doc

Is this a regression?

Yes, the previous version in which this bug was not present was: ....

Description

When I run this command:

ng new ivy4ever --experimentalIvy=true

I notice that the postInstall script isn't added to the package.json file.
Futhermore, should not we add the property aot: true to angular.json ?

"architect": {
        "build": {
          "builder": "@angular-devkit/build-angular:browser",
          "options": {
            "aot": true,
...

🔬 Minimal Reproduction

ng new ivy4ever --experimentalIvy=true

🌍 Your Environment



Angular CLI: 7.2.4
Node: 10.10.0
OS: darwin x64
Angular: 7.2.4
... animations, cli, common, compiler, compiler-cli, core, forms
... language-service, platform-browser, platform-browser-dynamic
... router

Package                           Version
-----------------------------------------------------------
@angular-devkit/architect         0.12.4
@angular-devkit/build-angular     0.12.4
@angular-devkit/build-optimizer   0.12.4
@angular-devkit/build-webpack     0.12.4
@angular-devkit/core              7.2.4
@angular-devkit/schematics        7.2.4
@ngtools/webpack                  7.2.4
@schematics/angular               7.2.4
@schematics/update                0.12.4
rxjs                              6.3.3
typescript                        3.2.4
webpack                           4.28.4


Anything else relevant?

Activity

  1. alan-agius4 commented on Feb 11, 2019

    @alan-agius4
    Collaborator

    @wKoza, you need to generate the project, using the latest version to the CLI. As the post install feature was introduced in 7.3.0.

    With regards to the aot option, I am assuming that you want to turn this on, to use the ngtsc compiler in dev mode. I'm not sure, if we should do this by default. Maybe @filipesilva knows more about this as he is currently working on some Ivy stuff.

  2. added this to the needsTriage milestone on Feb 11, 2019
  3. wKoza commented on Feb 11, 2019

    @wKoza
    ContributorAuthor

    arff OK perfect. With regards to the aot option, I refer, indeed, to the work of @filipesilva in this PR .
    => I change my title / description

  4. changed the title [-][ivy] ng new ivy4ever --experimentalIvy=true doesn't add postInstall script[/-] [+][ivy] ng new ivy4ever --experimentalIvy=true doesn't add aot: true option[/+] on Feb 11, 2019
  5. filipesilva commented on Feb 11, 2019

    @filipesilva
    Contributor

    @wKoza we don't yet add aot: true here because we've identified a performance regression, but the plan is still to add it for 8.0

  6. angular-automatic-lock-bot commented on Sep 9, 2019

    @angular-automatic-lock-bot

    This issue has been automatically locked due to inactivity.
    Please file a new issue if you are encountering a similar or related problem.

    Read more about our automatic conversation locking policy.

    This action has been performed automatically by a bot.

  7. locked and limited conversation to collaborators on Sep 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions