This repository was archived by the owner on Apr 4, 2025. It is now read-only.
Repository navigation
Add example of how to use an npm commonjs package like date-fns in ts_devserver & ts_web_test_suite - #343
Merged
gregmagolan merged 2 commits intoApr 2, 2019
Conversation
…_devserver & ts_web_test_suite
Contributor
Author
|
This works for shallow imports from npm packages such as |
Contributor
|
Could you add some text here so ppl know this is a temp solution and we plan something more ergonomic for 8? |
alexeagle
approved these changes
Apr 2, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This solution works but it requires too much boilerplate code per npm module to scale. Still working on a general solution that scales. See bazel-contrib/rules_nodejs#646.