This repository was archived by the owner on Apr 4, 2025. It is now read-only.
Repository navigation
Install bazel from npm, don't depend on user to do it manually - #231
Merged
Merged
Conversation
alexeagle
force-pushed
the
bazel_from_npm
branch
8 times, most recently
from
November 19, 2018 21:49
826df0f to
b4c0491
Compare
gregmagolan
approved these changes
Nov 19, 2018
| working_directory: ~/ng | ||
| docker: | ||
| - image: *docker_image | ||
| - image: circleci/node:10.12-browsers |
Contributor
There was a problem hiding this comment.
nit: comment on why -browers image is needed?
| ```bash | ||
| $ yarn e2e | ||
| # or | ||
| $ bazel test //e2e:all |
Contributor
There was a problem hiding this comment.
nit: //e2e/... would also hit targets that are in sub-packages
Update README to explain install This repo works with either Bazel or Yarn, you need only one of them
alexeagle
force-pushed
the
bazel_from_npm
branch
from
November 19, 2018 22:18
b4c0491 to
9771a5b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.