@yjbanov yeh, this was my initial proposal but I've changed this as requested by @mhevery

Personally I'm on the fence - on one hand it make sense to have them duplicated but it is duplication so it might happen that people add things for dart and not JS or vice-versa (although tests should catch this).

In short: I don't mind either way, maybe @mhevery should do the final call here.

As for @mhevery's request to dedupe the values, the way I see it, JS has its mappings, Dart has its own mappings. Some of these mappings are the same, but that's purely a coincidence. I'm not worried that one would forget to add a mapping. It should be caught by tests, but even if its not caught, its trivial to fix once discovered.

@yjbanov as I've said, I don't feel strongly about dedupe so it is LGTM from my side.

That's good enough for me. I'll fight it out with Misko later, if he objects. Not that hard to change back.

Find with me for now.

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}