refactor(core): type ComponentRef, ComponentFactory and `Componen…
#8361
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tFixture` by the component type BREAKING CHANGE: - `ComponetRef`, `ComponentFactory`, `ComponentFixture` now all require a type parameter with the component type.
| "version": "0.9.9", | ||
| "from": "ts2dart@0.9.9", | ||
| "version": "0.9.10", | ||
| "from": "ts2dart@>=0.9.9 <0.10.0", |
Contributor
There was a problem hiding this comment.
The fact that I see a range here seems odd to me.
Contributor
Author
There was a problem hiding this comment.
This was produced by running tools/npm/reshrinkwrap. I could change it manually, but seems ot be fine (as there is a resolved property afterwards with the exact number)
Contributor
|
LGTM, love it. |
mhevery
added
pr_state: LGTM
action: merge
|
Merging PR #8361 on behalf of @mprobst to branch presubmit-mprobst-pr-8361. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.