Skip to content

Conversation

@alexeagle
Copy link
Contributor

Tested by running this with a different replacement marker string and grepping all .d.ts files for that marker, to be sure it only triggers on the two lines in angular2/src/alt_router/metadata/metadata.d.ts

Fixes angular2/src/alt_router/metadata/metadata.d.ts
@alexeagle alexeagle added the action: review The PR is still awaiting reviews from at least one requested reviewer label Apr 29, 2016
@alexeagle alexeagle assigned hansl and unassigned IgorMinar Apr 29, 2016
@hansl hansl added pr_state: LGTM action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Apr 29, 2016
@mary-poppins
Copy link

Merging PR #8339 on behalf of @hansl to branch presubmit-hansl-pr-8339.

@alexeagle
Copy link
Contributor Author

for the record, we need to instead prevent using 1.9 features in our code by running all .d.ts files through TS typechecker in the typescript_next build.

This is just a quick hack to unblock the release.

@chuckjaz is thinking of using a TS language service to do downleveling, but I think we only need that for features we can't avoid using (eg. readonly)

@IgorMinar
Copy link
Contributor

lgtm! thanks

@mary-poppins
Copy link

Merging PR #8339 on behalf of @mprobst to branch presubmit-mprobst-pr-8339.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker cla: yes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants