Alt Router: Support aux routes/RouterLink/Location #8220
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vsavkin
added
the
action: review
vsavkin
force-pushed
the
support_aux_routes
branch
from
80b6a71 to
bc030f6
Compare
Contributor
There was a problem hiding this comment.
Make "aux" an overridable default?
vsavkin
force-pushed
the
support_aux_routes
branch
from
bc030f6 to
4affc9a
Compare
| @HostBinding() private href: string; | ||
|
|
||
| constructor(private _router: Router, private _segment: RouteSegment) { | ||
| this._subscription = ObservableWrapper.subscribe(_router.changes, (_) => { |
vsavkin
force-pushed
the
support_aux_routes
branch
from
9e01219 to
17d1e1b
Compare
vsavkin
changed the title
vsavkin
force-pushed
the
support_aux_routes
branch
from
17d1e1b to
143fd1e
Compare
Contributor
Author
|
Did a walkthrough with Misko |
vsavkin
added
action: merge
vsavkin
force-pushed
the
support_aux_routes
branch
from
143fd1e to
0ab8037
Compare
|
Merging PR #8220 on behalf of @mprobst to branch presubmit-mprobst-pr-8220. |
Contributor
|
Woohoo @vsavkin ! |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.