Skip to content

fix(forms): ensure select model updates in firefox and ie #8148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
kara wants to merge 1 commit into from
Closed

fix(forms): ensure select model updates in firefox and ie #8148

kara wants to merge 1 commit into from

Conversation

@kara
Copy link
Contributor

@kara kara commented Apr 20, 2016 •
edited
Loading

Fixes #6573

@kara kara added the action: review The PR is still awaiting reviews from at least one requested reviewer label Apr 20, 2016
vsavkin
vsavkin reviewed Apr 20, 2016
View reviewed changes
modules/angular2/test/common/forms/integration_spec.ts Outdated
Copy link
Contributor

@vsavkin vsavkin Apr 20, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you try using fakeAsync instead?

I know you had issues with it before, but maybe they have been fixed since then.

Copy link
Contributor Author

@kara kara Apr 20, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, I'll try it and we'll see if it still fails in Edge

@vsavkin vsavkin added pr_state: LGTM and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Apr 20, 2016
@kara kara added the action: merge The PR is ready for merge by the caretaker label Apr 20, 2016
@mary-poppins
Copy link

mary-poppins commented Apr 22, 2016

Merging PR #8148 on behalf of @rkirov to branch presubmit-rkirov-pr-8148.

@mhevery mhevery closed this in c3daccd Apr 22, 2016
@mik-laj mik-laj mentioned this pull request Apr 25, 2016
Closed
3 tasks
@kara kara deleted the firefox branch June 27, 2016 05:28
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Sep 8, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: forms cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

beta.1 ngModel/ngModelChange not working on select element in FireFox 43.0.4

5 participants

@kara @mary-poppins @vsavkin @rkirov @googlebot