-
Notifications
You must be signed in to change notification settings - Fork 27k
add compilation error test for dart #812
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
93913b5 to
f86e821
Compare
|
@b-laporte actually I've tried this yesterday, it was not working, somebody else should have fixed someting... |
|
Could it be a side effect of 9b08ab3 ? |
|
Humm... I still have errors in Dart for
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
isn't expect().toEqual() ok here ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't check toEqual() - but toBe() doesn't work as it seems we get a raw string in Dart... ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok - toEqual does work - so I will submit an update - thx!
f86e821 to
c07f265
Compare
|
@vicb yes indeed something has changed as this PR didn't work yesterday - and I actually prepared another PR to include |
c07f265 to
c2ea645
Compare
|
In Dart you can have I haven't had time to check what is wrong with the Promise/Future error handling. We should create an issue to investigate, can you do it ? |
c2ea645 to
23c30fb
Compare
|
@ViB I would be fine to open an issue - but for this I need a error sample, and I can't reproduce it anymore - what happened was that the error was not caught in internal try/catch and was caught in the zone instead. But now everything works as expected.. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This PR unlocks the directive validation error tests for dart. Apparently some previous cleanup done by @vicb allows them to work without using
Future.sync()- thanks !