fix(angular_1_router): Removed arrow function from module template #8076
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Failed build was a flake |
Contributor
|
LGTM. Thanks @brandonroberts |
petebacondarwin
added
pr_state: LGTM
action: merge
|
Merging PR #8076 on behalf of @robertmesserle to branch presubmit-robertmesserle-pr-8076. |
|
Merging PR #8076 on behalf of @robertmesserle to branch presubmit-robertmesserle-pr-8076. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug fix
Angular 1 Router breaks in IE due to fat arrow function not being transpiled
Allows angular 1 router to function in IE without breaking
No
Closes #7913 #8074
cc: @petebacondarwin