Skip to content

docs(markdown): update markdown headers #7996

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ericjim wants to merge 1 commit into from
Closed

docs(markdown): update markdown headers #7996

ericjim wants to merge 1 commit into from

Conversation

@ericjim
Copy link
Member

@ericjim ericjim commented Apr 9, 2016

  • Please check if the PR fulfills these requirements
  • The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit-message-format
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    Minor update ng_form_control.ts, there is a missing space between ### and ngModel.

@naomiblack we are also decreasing the size of the headers inside the documentation from h1s to h3s.

  • What is the current behavior? (You can also link to an open issue here)
    Looks like this in production:
    screenshot 2016-04-09 16 29 18
    Notice the markdown in the subtitle ngModel.
  • What is the new behavior (if this is a feature change)?
    This is how it looks after adding the missing space.
    screenshot 2016-04-09 16 29 05
  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
    Rebuild documentation for angular.io

@ericjim ericjim changed the title docs(ng_form_control): add missing space between markdown ### and text docs(markdown): update markdown headers Apr 13, 2016
@naomiblack naomiblack added pr_state: LGTM action: merge The PR is ready for merge by the caretaker labels Apr 16, 2016
@naomiblack
Copy link
Contributor

naomiblack commented Apr 16, 2016

You can see the effect of this in the docs that are live on angular.io now (e.g. https://angular.io/docs/ts/latest/api/common/NgFor-directive.html) -- I've pushed from a branch that has this commit. Please merge. Non-controversial docs fix.

@robertmesserle
Copy link

robertmesserle commented Apr 18, 2016

@ericjim Can you squash this into a single commit?

@ericjim
Copy link
Member Author

ericjim commented Apr 18, 2016

@robertmesserle, done.

@mary-poppins
Copy link

mary-poppins commented Apr 20, 2016

Merging PR #7996 on behalf of @robertmesserle to branch presubmit-robertmesserle-pr-7996.

@mhevery mhevery closed this in 45f5df3 Apr 20, 2016
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Sep 8, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ericjim @naomiblack @robertmesserle @mary-poppins @googlebot