Skip to content

feat(DomAdapter): allow "global" for getGlobalEventTarget #7979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
PatrickJS wants to merge 1 commit into from
Closed

feat(DomAdapter): allow "global" for getGlobalEventTarget #7979

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion modules/angular2/src/platform/browser/browser_adapter.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -438,7 +438,7 @@ class BrowserDomAdapter extends GenericBrowserDomAdapter {
}

getGlobalEventTarget(String target) {
if (target == "window") {
if (target == "window" || target == "global") {
return window;
} else if (target == "document") {
return document;
Expand Down
6 changes: 3 additions & 3 deletions modules/angular2/src/platform/browser/browser_adapter.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -309,11 +309,11 @@ export class BrowserDomAdapter extends GenericBrowserDomAdapter {
return key;
}
getGlobalEventTarget(target: string): EventTarget {
if (target == "window") {
if (target === "window" || target === "global") {
return window;
} else if (target == "document") {
} else if (target === "document") {
return document;
} else if (target == "body") {
} else if (target === "body") {
return document.body;
}
}
Expand Down
6 changes: 3 additions & 3 deletions modules/angular2/src/platform/server/parse5_adapter.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -531,11 +531,11 @@ export class Parse5DomAdapter extends DomAdapter {
supportsDOMEvents(): boolean { return false; }
supportsNativeShadowDOM(): boolean { return false; }
getGlobalEventTarget(target: string): any {
if (target == "window") {
if (target === "window" || target === "global") {
return (<any>this.defaultDoc())._window;
} else if (target == "document") {
} else if (target === "document") {
return this.defaultDoc();
} else if (target == "body") {
} else if (target === "body") {
return this.defaultDoc().body;
}
}
Expand Down