-
Notifications
You must be signed in to change notification settings - Fork 27k
fix(compiler): properly bind to properties that don't have matching attr name #783
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(compiler): properly bind to properties that don't have matching attr name #783
Conversation
|
This is the first attempt at #619 but with few remark: I'm completely buying the idea of "fixing" property names where both attr and property exists (ex. |
ded03ba to
3800bbb
Compare
|
@pkozlowski-opensource Seems Travis fails because of |
|
@vicb yeh. That's bad since in JS it is |
|
So, the solutions I can see right now is to:
But yeh, I really don't feel good about "inventing" the @mhevery could we discuss this during / after the today's standup? |
3800bbb to
28e37d2
Compare
|
@mhevery I believe this is ready for the review. Just 2 items I'm unsure of:
|
|
I don't really get the point to create fake attributes that don't exist in the first place. @pkozlowski-opensource The goal being to be able to bind directly to properties, why not using directly the property name without any conversion (I know it is not solving the different case issue between Dart and JS, but from a user point of view, you will write either Dart or JS) ? Maybe I am missing the point on that topic... Regarding and |
|
@benouat there are 2 things to observe here:
|
|
The conversion from dash-case to camelCase should happen in UPDAT: I see you have already added it. Perfect |
modules/angular2/src/facade/dom.dart
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
readonly vs readOnly as well
|
Please fix the comments and it should be ready to go. |
28e37d2 to
49ecba4
Compare
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Fixes #619