Skip to content

feat(transformers): collect provider information #7380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
vsavkin wants to merge 3 commits into from
Closed

feat(transformers): collect provider information #7380

vsavkin wants to merge 3 commits into from

Conversation

@vsavkin
Copy link
Contributor

@vsavkin vsavkin commented Mar 2, 2016

No description provided.

@vsavkin vsavkin added the action: review The PR is still awaiting reviews from at least one requested reviewer label Mar 2, 2016
tbosch
tbosch reviewed Mar 2, 2016
View reviewed changes
modules_dart/transform/test/transform/directive_processor/all_tests.dart Outdated
Copy link
Contributor

@tbosch tbosch Mar 2, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove ddescribe

@tbosch tbosch added pr_state: LGTM action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Mar 2, 2016
@vsavkin vsavkin force-pushed the transformers_providers branch from 58fba4c to 5d63b28 Compare March 2, 2016 19:17
@vsavkin vsavkin added action: merge The PR is ready for merge by the caretaker and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Mar 2, 2016
@vikerman
Copy link
Contributor

vikerman commented Mar 4, 2016

TAP Green

@mary-poppins
Copy link

mary-poppins commented Mar 4, 2016

Merging PR #7380 on behalf of @vikerman to branch presubmit-vikerman-pr-7380.

@vikerman
Copy link
Contributor

vikerman commented Mar 4, 2016

Manually merged.

@vikerman vikerman closed this Mar 4, 2016
@vikerman vikerman reopened this Mar 4, 2016
@vikerman
Copy link
Contributor

vikerman commented Mar 4, 2016

Broke Google3. Saw the TAP presubmit result from a wrong run before merging :(

@vsavkin vsavkin force-pushed the transformers_providers branch 3 times, most recently from 192a01c to b98ee49 Compare March 7, 2016 20:44
@vikerman
Copy link
Contributor

vikerman commented Mar 7, 2016

https://test.corp.google.com/ui#id=OCL:116549158:BASE:116549176:1457368560962:4d245865

@vikerman vikerman removed the action: merge The PR is ready for merge by the caretaker label Mar 8, 2016
@vsavkin vsavkin force-pushed the transformers_providers branch 3 times, most recently from 27d5633 to d43a7ac Compare March 9, 2016 23:26
@tbosch tbosch added the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Mar 10, 2016
@tbosch tbosch assigned vsavkin and unassigned tbosch Mar 10, 2016
@vsavkin vsavkin force-pushed the transformers_providers branch from d43a7ac to e3c4b25 Compare March 11, 2016 15:40
@vsavkin vsavkin force-pushed the transformers_providers branch 5 times, most recently from 92eccef to 555131a Compare March 28, 2016 22:08
@vsavkin vsavkin force-pushed the transformers_providers branch 9 times, most recently from 53c5491 to af2b4e1 Compare March 31, 2016 22:53
@vsavkin
feat(transformers): changes transformers to collect information about…
427cc7a 
… providers and resolve identifiers during linking
@vsavkin vsavkin force-pushed the transformers_providers branch from af2b4e1 to 427cc7a Compare April 4, 2016 17:32
@vsavkin vsavkin added action: merge The PR is ready for merge by the caretaker zomg_admin: do merge labels Apr 4, 2016
@mary-poppins
Copy link

mary-poppins commented Apr 4, 2016

Merging PR #7380 on behalf of @vsavkin to branch presubmit-vsavkin-pr-7380.

1 similar comment
@mary-poppins
Copy link

mary-poppins commented Apr 4, 2016

Merging PR #7380 on behalf of @vsavkin to branch presubmit-vsavkin-pr-7380.

@mhevery mhevery closed this in 4e9809b Apr 4, 2016
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Sep 8, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

@vsavkin vsavkin

Labels

action: merge The PR is ready for merge by the caretaker cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@vsavkin @vikerman @mary-poppins @kegluneq @tbosch @naomiblack @googlebot