Repository navigation
Conversation
angular-robot
Bot
added
area: performance
NgControl kept RequiredValidator in the bundle just for an instanceof check. Use a private symbol instead so apps that don't use the directive can drop it.
Let selectValueAccessor recognize default and built-in accessors without keeping their implementation classes in every bundle. Signal forms can then drop the accessor classes and their inheritance helpers. Keep exact constructor checks so custom subclasses retain their priority. Update the existing bundle goldens.
SkyZeroZx
force-pushed
the
perf/forms-optional-directives-tree-shaking
branch
from
November 12, 2026 01:32
cdc38cc to
588444e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
perf(forms): let unused required validators be tree-shaken
NgControlkeptRequiredValidatorin the bundle just for an instanceof check. Use a private symbol instead so apps that don't use the directive can drop it.perf(forms): let unused value accessors be tree-shaken
Let
selectValueAccessorrecognize default and built-in accessors without keeping their implementation classes in every bundle. Signal forms can then drop the accessor classes and their inheritance helpers.Keep exact constructor checks so custom subclasses retain their priority. Update the existing bundle goldens.