Repository navigation
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
|
You need to remove Claude Code from the commit as it is now the co-author. Until you do CLA will fail regardless you signed it or not. |
|
Closing this PR so the proposal goes through the issue first, as the contributing guide asks. I'm reopening #71912 for that. The branch stays on my fork and I'll only reopen a PR if the maintainers want one: https://github.com/GamerDubz/angular/tree/feat/claude-plugin-marketplace |
|
Reopening: the contributing guide lets small features go straight to a pull request and says an issue is ideal but not required. #71912 stays open and is linked above. |
c68cd62 to
c3e6134
Compare
GamerDubz
changed the title
c3e6134 to
f5a4d65
Compare
|
@GamerDubz the So the files should be in the |
f5a4d65 to
8d557d1
Compare
|
Thanks @geromegrignon, that makes sense. I moved the manifests into |
8d557d1 to
0538642
Compare
|
Thanks @erkamyaman, I removed the Claude co-author trailer from the amended commit, and |
Add Codex interface details, Claude marketplace listing fields, and the official Angular logo so marketplace listings show website, branding, and accurate skill descriptions. Co-authored-by: GamerDubz <GamerDubz@users.noreply.github.com>
8f552ba to
caf4a3b
Compare
GamerDubz
changed the title
PR Checklist
PR Type
skills/dev-skillsWhat is the current behavior?
The agent skills in
skills/dev-skillsare published toangular/skillsand installed withnpx skills add. There is no marketplace file, so agents cannot install them as a plugin.Issue Number: #71912
What is the new behavior?
Adds a generic agent marketplace (
skills/dev-skills/.agents/plugins/marketplace.json) so any compatible coding agent can find the existing Angular skills, plus Claude Code and Codex listings (skills/dev-skills/.claude-plugin/marketplace.jsonandskills/dev-skills/.codex-plugin/plugin.json) that share the same metadata (display name, logo, website, description). The plugin root isskills/dev-skills/. The skills themselves are not copied or changed, so there is still one source of truth.Install examples:
claude plugin marketplace add angular/skillsthenclaude plugin install angular@angularangular/skillsas a marketplace and enableangular@angularOther agents that read the
.agentsmarketplace format can add this repository as a marketplace and install the same plugin.The files sit inside
skills/dev-skillsbecause the publish script exports that folder to the root ofangular/skills, so the install examples above work againstangular/skillsafter the next publish.Does this PR introduce a breaking change?
Other information
Verified
claude plugin validate .passes, and a local checkout of this branch installed as a marketplace lists both skills from the real files inskills/dev-skills/..agentsmarketplace and Codex manifest follow the Codex plugin docs and loader (marketplace.rs,manifest.rs): alocalsource to the plugin root, and skill paths that start with./, stay inside the plugin root and each hold aSKILL.md.Not verified
marketplace add angular/skills) can only be tested once the files are published toangular/skills; I tested the same manifests from a local copy ofskills/dev-skills.Related: #71912 (kept open for discussion; the contributing guide lets small features go straight to a PR).
Thanks to @geromegrignon for pointing out that
angular/skillsis exported fromskills/dev-skillsbyscripts/ci/publish-snapshot-build-artifacts.sh, which is why the files live there rather than at the repository root. That script usesgit archive, which includes dot-folders, but I have not run the publish job.