Repository navigation
refactor(compiler): check that ng-container don't have class bindings - #71844
Merged
Merged
Conversation
angular-robot
Bot
added
the
area: compiler
Member
Author
|
TGP came back green. This is good to go. |
mattrbeck
approved these changes
Nov 7, 2026
| `Attribute bindings are not supported on ng-container. Use property bindings instead.`, | ||
| bound.sourceSpan, | ||
| ); | ||
| // TODO(v23): Enable this breaking change |
Member
There was a problem hiding this comment.
✨ The tests from #70808 were dropped here. Could we bring them into r3_template_transform_spec.ts as xit with a TODO(v23)? That's what the CSS-variable change did (shadow_css_spec.ts, dom_renderer_spec.ts), and it makes the v23 switch-over mechanical.
Member
Author
There was a problem hiding this comment.
Done! Added the tests from #70808 into r3_template_transform_spec.ts as xit with // TODO(v23): Enable this breaking change.
This is the same change as angular#70808 but for g3 only due to its breaking nature.
JeanMeche
force-pushed
the
g3-ngcontainer-class
branch
from
November 7, 2026 16:07
539f7ae to
1344b06
Compare
This was referenced Nov 8, 2026
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the same change as #70808 but for g3 only due to its breaking nature.