Skip to content

docs(forms): fix broken snippets and wrong statements in the signal forms guides - #71344

Merged
thePunderWoman merged 1 commit into
angular:mainfrom
MeAkib:docs/signal-forms-guide-fixes
Nov 10, 2026
Merged

thePunderWoman merged 1 commit into
angular:mainfrom
MeAkib:docs/signal-forms-guide-fixes

Conversation

@MeAkib

@MeAkib MeAkib commented Oct 14, 2026

Copy link
Copy Markdown
Contributor
  • async-operations: fix the invalid object literal in the parse example, and point the HTTP options tip to HttpResourceRequest, which holds the request properties.
  • validation: fix the "multiple errors" example (a@b is a valid email address for the email() validator, a@ isn't), add the missing signal import, use one zod import style, and clarify that dynamic schemas are passed as a function.
  • migration: use extractValue() to get the whole form value instead of building it manually, and fix the expected output.
  • form-logic: refer to the FormField directive by name, release the timer when the debounce example is aborted, and add the missing form import.

@pullapprove
pullapprove Bot requested a review from kirjs October 14, 2026 06:04
@angular-robot angular-robot Bot added area: docs Related to the documentation area: forms labels Oct 14, 2026
@ngbot ngbot Bot added this to the Backlog milestone Oct 14, 2026
…orms guides

- async-operations: fix the invalid object literal in the `parse`
  example, and point the HTTP options tip to `HttpResourceRequest`,
  which holds the request properties.
- validation: fix the "multiple errors" example (`a@b` is a valid email
  address for the `email()` validator, `a@` isn't), use one zod import
  style, and clarify that dynamic schemas are passed as a function.
- migration: use `extractValue()` to get the whole form value instead of
  building it manually, and fix the expected output.
- form-logic: refer to the `FormField` directive by name, and release
  the timer when the `debounce` example is aborted.
@MeAkib
MeAkib force-pushed the docs/signal-forms-guide-fixes branch from 332efb1 to 8b8fa8c Compare November 1, 2026 13:04
@JeanMeche
JeanMeche removed the request for review from kirjs November 10, 2026 23:47
@JeanMeche JeanMeche added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Nov 10, 2026
@thePunderWoman
thePunderWoman merged commit 02a6282 into angular:main Nov 10, 2026
27 checks passed
@thePunderWoman

Copy link
Copy Markdown
Contributor

This PR was merged into the repository. The changes were merged into the following branches:

@MeAkib
MeAkib deleted the docs/signal-forms-guide-fixes branch November 11, 2026 03:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

action: merge The PR is ready for merge by the caretaker area: docs Related to the documentation area: forms target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants