docs: stop the disabled aria toolbar radio group from changing selection - #70685
Merged
atscott merged 1 commit intoSep 11, 2026
Merged
Conversation
The disabled toolbar example marks its alignment radio group `disabled`. Toolbars are soft-disabled by default, so the widgets only receive `aria-disabled` and stay clickable, which the guide describes as focusable but unavailable. Since angular#70516 moved selection into the app, each radio also carries a `(click)="alignment.set(...)"` handler that never checks the disabled state. Clicking a disabled radio therefore changes the selection. Before that change the radios had no app listener and the library ignored clicks on disabled items. Drop the three click handlers from the permanently disabled group in the basic, material and retro variants, the same way the disabled redo button in the same template already has none.
JeanMeche
added
action: merge
atscott
added
target: minor
Contributor
|
This PR was merged into the repository. The changes were merged into the following branches:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On next.angular.dev/guide/aria/toolbar#disabled-widgets the alignment buttons
are disabled, but clicking one still selects it. #70516 added a click handler to
each radio when it moved selection into the app, and soft-disabled widgets stay
clickable, so nothing stops it. This drops the three handlers from the disabled
group, like the disabled redo button next to it.
https://next.angular.dev/guide/aria/toolbar#disabled-widgets
Before:
(clicking "align right" selects it even though the group is disabled):
After:
(focus moves, selection stays on "align left"):