refactor(compiler-cli): relax nullish coalescing non nullable diagnostics on indexed access - #70656
Merged
Merged
Conversation
angular-robot
Bot
added
the
area: compiler
JeanMeche
marked this pull request as ready for review
September 9, 2026 23:36
JeanMeche
requested review from
mattrbeck
and removed request for
atscott and
josephperrott
September 9, 2026 23:36
JeanMeche
force-pushed
the
fix-nullish-coalescing-check
branch
from
September 9, 2026 23:37
234d015 to
3f98f84
Compare
mattrbeck
approved these changes
Sep 10, 2026
JeanMeche
force-pushed
the
fix-nullish-coalescing-check
branch
from
September 10, 2026 00:10
c66c6f8 to
e8c0e63
Compare
Member
Author
|
Addressed the review comments by adding |
JeanMeche
force-pushed
the
fix-nullish-coalescing-check
branch
from
September 10, 2026 00:17
b92ba8d to
ea6c4e0
Compare
JeanMeche
force-pushed
the
fix-nullish-coalescing-check
branch
from
September 10, 2026 09:10
ea6c4e0 to
998667b
Compare
alan-agius4
approved these changes
Sep 10, 2026
Member
Author
|
note: The extended diagnostic is globally disabled in g3 (since we landed the optional chaining change) , no need for a TGP here. |
JeanMeche
force-pushed
the
fix-nullish-coalescing-check
branch
2 times, most recently
from
September 10, 2026 09:18
6eb28a5 to
4187898
Compare
JeanMeche
added
action: merge
JeanMeche
force-pushed
the
fix-nullish-coalescing-check
branch
from
September 10, 2026 20:45
4187898 to
f0dd648
Compare
…tics on indexed access When noUncheckedIndexedAccess is not enabled, indexed accesses do not include undefined in the type. This relaxes the check for nullish coalescing similarly to optional chaining. Fixes angular#70655 fixes angular#70655
JeanMeche
force-pushed
the
fix-nullish-coalescing-check
branch
from
September 10, 2026 20:48
f0dd648 to
d31cabb
Compare
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When noUncheckedIndexedAccess is not enabled, indexed accesses do not include undefined in the type. This relaxes the check for nullish coalescing similarly to optional chaining.
Fixes #70655