Repository navigation
fix(forms #70627): prevent eager materialization of signal form children during garbage collection - #70633
Closed
seshan18 wants to merge 1 commit into
Closed
fix(forms #70627): prevent eager materialization of signal form children during garbage collection#70633seshan18 wants to merge 1 commit into
seshan18 wants to merge 1 commit into
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
seshan18
changed the title
|
This pull request has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes : #70627
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Currently, the lazy instantiation logic for Signal form fields (introduced in
98c5afdb) is inadvertently bypassed. The field management garbage collection effect inmanager.tscallsstructure.children()while tracking live structures. Calling.children()internally triggersensureChildrenMap(), which recursively forces the entire form tree to materialize synchronously in the next event loop tick.When initializing a form with a massive data array (e.g., thousands of items), this synchronous eager materialization locks the main thread and causes the browser to crash with a
SIGILL(out-of-memory) error.Issue Number: #70627
What is the new behavior?
The
markStructuresLivefunction inmanager.tsnow usesstructure.materializedChildren()instead ofstructure.children().This ensures that the garbage collector only crawls nodes that have already been instantiated. This fully preserves the laziness intended by the previous optimization commit and prevents out-of-memory crashes on forms containing massive datasets, without altering any functionality.
Does this PR introduce a breaking change?
Yes
No