docs: decouple selection from aria toolbar examples and guide - #70516
Merged
Merged
Conversation
ok7sai
force-pushed
the
refactor/toolbar-selection
branch
from
September 2, 2026 06:19
ddd8b79 to
6ab5231
Compare
ok7sai
marked this pull request as ready for review
September 2, 2026 06:38
Member
|
The preview is currently broken but doesn't that change need for us to update angular aria to the next version ? (and we should only target minor ? ) Edit: I see that aria was released and it will be bump by #70523 . |
JeanMeche
requested review from
JeanMeche
and removed request for
bencodezen
September 2, 2026 10:42
JeanMeche
force-pushed
the
refactor/toolbar-selection
branch
from
September 2, 2026 10:53
6ab5231 to
1727273
Compare
JeanMeche
approved these changes
Sep 2, 2026
1 task
Member
|
This PR was merged into the repository. The changes were merged into the following branches:
|
atscott
pushed a commit
that referenced
this pull request
Sep 11, 2026
The disabled toolbar example marks its alignment radio group `disabled`. Toolbars are soft-disabled by default, so the widgets only receive `aria-disabled` and stay clickable, which the guide describes as focusable but unavailable. Since #70516 moved selection into the app, each radio also carries a `(click)="alignment.set(...)"` handler that never checks the disabled state. Clicking a disabled radio therefore changes the selection. Before that change the radios had no app listener and the library ignored clicks on disabled items. Drop the three click handlers from the permanently disabled group in the basic, material and retro variants, the same way the disabled redo button in the same template already has none.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
For context angular/components#33747
Does this PR introduce a breaking change?
Other information