Skip to content

docs: decouple selection from aria toolbar examples and guide - #70516

Merged
mattrbeck merged 1 commit into
angular:mainfrom
ok7sai:refactor/toolbar-selection
Sep 2, 2026
Merged

mattrbeck merged 1 commit into
angular:mainfrom
ok7sai:refactor/toolbar-selection

Conversation

@ok7sai

@ok7sai ok7sai commented Sep 2, 2026

Copy link
Copy Markdown
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.dev application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

For context angular/components#33747

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@angular-robot angular-robot Bot added the area: docs Related to the documentation label Sep 2, 2026
@ngbot ngbot Bot added this to the Backlog milestone Sep 2, 2026
@ok7sai ok7sai changed the title docs: update decouple selection from aria toolbar examples and guide docs: decouple selection from aria toolbar examples and guide Sep 2, 2026
@ok7sai
ok7sai force-pushed the refactor/toolbar-selection branch from ddd8b79 to 6ab5231 Compare September 2, 2026 06:19
@ok7sai
ok7sai marked this pull request as ready for review September 2, 2026 06:38
@JeanMeche

JeanMeche commented Sep 2, 2026

Copy link
Copy Markdown
Member

The preview is currently broken but doesn't that change need for us to update angular aria to the next version ? (and we should only target minor ? )

Edit: I see that aria was released and it will be bump by #70523 .
Edit2: #70523 actually needs a takeover to that fixes the aria changes. This will be it.

@JeanMeche
JeanMeche requested review from JeanMeche and removed request for bencodezen September 2, 2026 10:42
@JeanMeche
JeanMeche force-pushed the refactor/toolbar-selection branch from 6ab5231 to 1727273 Compare September 2, 2026 10:53
@pullapprove
pullapprove Bot requested a review from alan-agius4 September 2, 2026 10:53
@JeanMeche
JeanMeche removed the request for review from MarkTechson September 2, 2026 10:55
@mattrbeck mattrbeck added action: merge The PR is ready for merge by the caretaker target: minor This PR is targeted for the next minor release and removed adev: preview labels Sep 2, 2026
@mattrbeck
mattrbeck merged commit d7af4b5 into angular:main Sep 2, 2026
24 of 27 checks passed
@mattrbeck

Copy link
Copy Markdown
Member

This PR was merged into the repository. The changes were merged into the following branches:

@ok7sai
ok7sai deleted the refactor/toolbar-selection branch September 3, 2026 00:13
atscott pushed a commit that referenced this pull request Sep 11, 2026
The disabled toolbar example marks its alignment radio group `disabled`.
Toolbars are soft-disabled by default, so the widgets only receive
`aria-disabled` and stay clickable, which the guide describes as focusable
but unavailable.

Since #70516 moved selection into the app, each radio also carries a
`(click)="alignment.set(...)"` handler that never checks the disabled state.
Clicking a disabled radio therefore changes the selection. Before that change
the radios had no app listener and the library ignored clicks on disabled
items.

Drop the three click handlers from the permanently disabled group in the
basic, material and retro variants, the same way the disabled redo button in
the same template already has none.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

action: merge The PR is ready for merge by the caretaker area: docs Related to the documentation target: minor This PR is targeted for the next minor release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants