Repository navigation
Conversation
angular-robot
Bot
added
the
area: compiler
Partial component declarations are linked in the consuming application and must not have their CSS variable names rewritten with the application's namespace. Disable namespace placeholder insertion for partial linker and JIT declaration compilation while retaining global prefix normalization. Fixes angular#70064
splincode
force-pushed
the
splincode/fix-css-var-namespacing-libraries
branch
from
September 17, 2026 19:08
c889128 to
d8a6de2
Compare
Member
|
I don't think that unconditionnaly remove the scoping is the right solution here. |
|
This pull request has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
The partial linker runs component styles through CSS variable namespacing while compiling a consuming application. As a result, public CSS variables in third-party library styles receive the application namespace and no longer match global theme variables.
Issue Number: Fixes #70064
What is the new behavior?
Partial component styles preserve ordinary CSS variable names when they are linked, including the JIT declaration path. The linker still removes the
--global--opt-out prefix so partial declarations retain its existing normalization semantics. Full compilation remains unchanged and continues to emit%NS%placeholders for application component styles.Regression coverage verifies the partial linker output, JIT declarations, the CSS transformation helper, and distinct full-versus-linked compliance output.
Does this PR introduce a breaking change?