Repository navigation
Conversation
Treat explicitly namespaced ng-template elements like their HTML counterparts when collecting attributes for directive matching. This prevents used standalone directives from being reported as unused. Fixes angular#70471
angular-robot
Bot
added
the
area: compiler
Member
|
Dupe #70474 |
|
This pull request has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
PR Type
What is the current behavior?
Explicit
ng-templateelements nested inside SVG are represented with a namespaced tag name. Attribute collection for directive matching compares the tag name directly withng-template, so these nodes are treated like structural templates. As a result, directives such asNgTemplateOutletdo not match and can be incorrectly reported as unused by NG8113.Fixes #70471.
What is the new behavior?
Recognize
ng-templateelements independently of their namespace when collecting attributes for directive matching. Directives applied tong-templateinside SVG now match and are included in the component's used directives.The regression test covers the minimized reproduction from the issue.
Does this PR introduce a breaking change?