Skip to content

fix(compiler): correctly match directives on <ng-template> nested i… - #70474

Merged
kirjs merged 1 commit into
angular:mainfrom
JeanMeche:ng-template-svg
Oct 1, 2026
Merged

kirjs merged 1 commit into
angular:mainfrom
JeanMeche:ng-template-svg

Conversation

@JeanMeche

Copy link
Copy Markdown
Member

…n various namespaces

With this commit with correctly detect directive attached to ng-templates in namespaces

fixes #70471

@JeanMeche
JeanMeche requested a review from crisbeto August 30, 2026 15:23
@angular-robot angular-robot Bot added the area: compiler Issues related to `ngc`, Angular's template compiler label Aug 30, 2026
@ngbot ngbot Bot added this to the Backlog milestone Aug 30, 2026
@JeanMeche
JeanMeche force-pushed the ng-template-svg branch 4 times, most recently from 8ee3e84 to a8550db Compare September 1, 2026 00:21
@JeanMeche
JeanMeche requested a review from mattrbeck September 10, 2026 23:04
@JeanMeche
JeanMeche force-pushed the ng-template-svg branch 2 times, most recently from 46c9f3b to 06c8088 Compare September 20, 2026 19:36
@JeanMeche JeanMeche added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Sep 21, 2026
@JeanMeche
JeanMeche removed the request for review from crisbeto September 21, 2026 22:30
@JeanMeche JeanMeche removed the action: merge The PR is ready for merge by the caretaker label Sep 22, 2026
…n various namespaces

With this commit with correctly detect directive attached to ng-templates in namespaces

fixes angular#70471
@JeanMeche JeanMeche added the action: merge The PR is ready for merge by the caretaker label Sep 30, 2026
@kirjs
kirjs merged commit a9d6b2f into angular:main Oct 1, 2026
25 checks passed
@kirjs

kirjs commented Oct 1, 2026

Copy link
Copy Markdown
Contributor

This PR was merged into the repository. The changes were merged into the following branches:

@angular-automatic-lock-bot

Copy link
Copy Markdown

This pull request has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Nov 1, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker area: compiler Issues related to `ngc`, Angular's template compiler target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Warning for directive not used within the template, when it actually is

4 participants