Repository navigation
Conversation
…gular-developer skill Fixes #70132. AI coding agents using this skill were observed calling plain methods directly inside @for/@if template expressions (e.g. items(count) returning a fresh array every change-detection run), which is wasteful when the computation isn't trivial. Nothing in the skill's references previously called this out. Add a short, non-absolute note recommending computed() or a pure pipe for non-trivial work, while allowing plain calls for cheap/pure lookups — there's no maintainer consensus on banning function calls in templates outright.
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Member
|
You didn't sign the CLA, we cannot proceed with this PR. |
|
This pull request has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
angular-developerskill) generating templates that call plain methods directly inside@for/@ifexpressions, re-executing on every change-detection run.skills/dev-skills/angular-developer/SKILL.mdand allreferences/*.md— no existing guidance covers this.references/components.mdafter the@forsection: recommendcomputed()/a pure pipe for non-trivial work, but don't ban function calls outright — as discussed on the issue, there's no maintainer consensus that plain calls are always wrong (fine for cheap/pure lookups), so the note reflects that instead of a hard rule.Test plan