Repository navigation
fix(zone.js): guard against null handle when detecting refreshable timers - #70046
Merged
thePunderWoman merged 1 commit intoAug 3, 2026
Merged
Conversation
…mers A timer wrapper such as a browser extension, policy, or automation harness can block a call and return null instead of a handle. patchTimer then read `.refresh` on that null value and threw synchronously. Treat a nullish handle as non-refreshable so the patched timer keeps working. Fixes angular#70044
alan-agius4
approved these changes
Aug 3, 2026
alan-agius4
left a comment
alan-agius4
left a comment
Contributor
There was a problem hiding this comment.
LGTM, thanks for your contribution.
alan-agius4
added
action: merge
crisbeto
approved these changes
Aug 3, 2026
alan-agius4
added
action: merge
Contributor
|
This PR was merged into the repository. The changes were merged into the following branches:
|
|
This pull request has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A timer wrapper such as a browser extension or automation harness can block a call and return null instead of a handle.
patchTimerthen read.refreshon that null value and threwTypeError: Cannot read properties of null (reading 'refresh').This guards the refresh lookup so a nullish handle counts as non-refreshable, which keeps the numeric and Node.js handle behavior unchanged.
Fixes #70044